I'm just a newbie so I've been googling this and came up with the rule of taking profit at 20% up and placing a stop loss at 7%. That's what I've been doing but I've also realised that 20% is a heck of a rise to realise in practice... I believe its anything longer than a day trade but less than an investment held for more than a few months.